Repository navigation
Drop the Operations helpers nothing calls any more - #79
Merged
Merged
Conversation
loevgaard
force-pushed
the
fix/rejected-auto-capture
branch
from
August 17, 2026 09:39
0d477cd to
5180cfb
Compare
loevgaard
force-pushed
the
chore/drop-vestigial-operations-helpers
branch
from
August 17, 2026 09:39
3139f86 to
642eed3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #79 +/- ##
============================================
- Coverage 98.41% 98.38% -0.04%
+ Complexity 202 195 -7
============================================
Files 19 19
Lines 506 495 -11
============================================
- Hits 498 487 -11
Misses 8 8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Operations::latest(), isLatestApproved() and authorizedAmount() lost their last callers in src/ when StatusAction moved to the last APPROVED operation (#65) and ConfirmPaymentAction stopped capturing (#69). They were only ever there for those callers; keeping them would make them accidental public API to carry into 3.0. Gone before 2.0, tests with them. Refs #71 (A4).
loevgaard
force-pushed
the
chore/drop-vestigial-operations-helpers
branch
from
August 17, 2026 09:42
642eed3 to
cb0c056
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes A4 of #71. Stacked on #73 (which is stacked on #72) — all three touch
Operations.php; retarget to2.xbefore merging its base.Operations::latest(),isLatestApproved()andauthorizedAmount()lost their last callers insrc/whenStatusActionmoved to the last approved operation (#65) andConfirmPaymentActionstopped capturing (#69). They only ever existed for those callers; keeping them would make them accidental public API to carry into 3.0. Dropped before 2.0, with their tests; CLAUDE.md's helper list updated (latestOfType()from #72 is the one addition).composer allgreen.